Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38Packages.zetup: fix build #83570

Merged
merged 1 commit into from Mar 28, 2020
Merged

python38Packages.zetup: fix build #83570

merged 1 commit into from Mar 28, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 28, 2020

Currently fails to build on python 3.8 due to an overly restrictive version bound.

ZHF: #80379

CC @NixOS/nixos-release-managers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
python38Packages.zetup: fix build
a65e052 
Currently fails to build on python 3.8 due to an overly restrictive version bound.

ZHF: NixOS#80379

CC @NixOS/nixos-release-managers
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build python37Packages.zetup

@worldofpeace
Copy link
Contributor

Could you attach a build log from hydra with the failing build?
It would be helpful to do that with all ZHF PRs or for any build fix.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

Sure, I'll start doing that. Here's zetup on 20.03:
https://hydra.nixos.org/build/115539216

@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

Or I guess this is the more useful URL to link, since it shows the repeated pattern of failures on release-20.03?
https://hydra.nixos.org/job/nixos/release-20.03/nixpkgs.python38Packages.zetup.x86_64-linux

@worldofpeace
Copy link
Contributor

Or I guess this is the more useful URL to link, since it shows the repeated pattern of failures on release-20.03?
https://hydra.nixos.org/job/nixos/release-20.03/nixpkgs.python38Packages.zetup.x86_64-linux

The build would be best, I don't think you can do permanent time ranges, and eventually that will advance into the future where you won't see that pattern anymore.

@worldofpeace worldofpeace merged commit 1495eb3 into NixOS:master Mar 28, 2020
This was referenced Mar 28, 2020
Closed
Merged
@bhipple bhipple deleted the fix/zetup branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @worldofpeace