Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] haskellPackages.hspec-core: Disable tests on i686 #83572

Merged
merged 1 commit into from Mar 28, 2020
Merged

[20.03] haskellPackages.hspec-core: Disable tests on i686 #83572

merged 1 commit into from Mar 28, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 28, 2020

Motivation for this change

Backport of #83571.

The tests have x86_64 results hardcoded, see hspec/hspec#431.

CC @NixOS/nixos-release-managers
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
haskellPackages.hspec-core: Disable tests on i686.
1f6b1cb 
The tests have x86_64 results hardcoded, see
hspec/hspec#431.

(cherry picked from commit 59e77d45b234162e2a6b804fe9c1462e6089afe8)
@nh2 nh2 requested a review from peti March 28, 2020 03:08
@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
cdepillabout
cdepillabout approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdepillabout cdepillabout merged commit adc01b5 into NixOS:release-20.03 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@bhipple bhipple bhipple approved these changes

@peti peti Awaiting requested review from peti

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @cdepillabout @bhipple