mullvad-vpn: add libappindicator dependency and fix mullvad-problem-report link #83621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding libappindicator as a runtime dependency allows the Electron-based gui app to have an appindicator in desktop environments that support them (eg, Gnome with the appindicator support extension).
cgevans
force-pushed
the
fix-mullvad-appindicator2
branch
from
029a1e4
to
061e73c
Compare
cgevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding libappindicator as a runtime dependency allows the Electron-based gui app
to have an appindicator in desktop environments that support them (eg,
Gnome with the appindicator support extension).
Also, previous versions had a broken link in bin/ (mullvad-problem-report) that I noticed while filling out the PR checklist. I have added a commit to fix this.
I have tested that this is compatible with #80721 and #70762. In particular, #80721 really needs to be merged.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)(mullvad-problem-report does not work before or after this change)(now fixed by second commit)nix path-info -Sbefore and after)