Skip to content

mullvad-vpn: add libappindicator dependency and fix mullvad-problem-report link #83621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

cgevans
Copy link
Contributor

@cgevans cgevans commented Mar 28, 2020

Motivation for this change

Adding libappindicator as a runtime dependency allows the Electron-based gui app
to have an appindicator in desktop environments that support them (eg,
Gnome with the appindicator support extension).

Also, previous versions had a broken link in bin/ (mullvad-problem-report) that I noticed while filling out the PR checklist. I have added a commit to fix this.

I have tested that this is compatible with #80721 and #70762. In particular, #80721 really needs to be merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (mullvad-problem-report does not work before or after this change) (now fixed by second commit)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
NeQuissimus Tim Steinbach
Adding libappindicator as a runtime dependency allows the Electron-based gui app
to have an appindicator in desktop environments that support them (eg,
Gnome with the appindicator support extension).
@cgevans cgevans force-pushed the fix-mullvad-appindicator2 branch from 029a1e4 to 061e73c Compare March 28, 2020 21:00
@ofborg ofborg bot requested a review from Br1ght0ne March 28, 2020 21:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 28, 2020
@cgevans cgevans changed the title mullvad-vpn: add appindicator dependency mullvad-vpn: add libappindicator dependency and fix mullvad-problem-report link Mar 28, 2020
@marsam marsam merged commit 9644e10 into NixOS:master Apr 1, 2020
@cgevans cgevans deleted the fix-mullvad-appindicator2 branch April 1, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants