Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydra-unstable: Fix eval with allowAliases = false #83635

Merged
merged 1 commit into from Mar 29, 2020
Merged

hydra-unstable: Fix eval with allowAliases = false #83635

merged 1 commit into from Mar 29, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 29, 2020 •
edited

Motivation for this change
  • Catalyst::Plugin::Unicode::Encoding has been merged into Catalyst::Runtime
  • Test::More is apparently part of Perl core modules since 5.6.2? (cd57558)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
hydra-unstable: Fix eval with allowAliases = false
dc88e94 
* Catalyst::Plugin::Unicode::Encoding has been merged into Catalyst::Runtime
* Test::More is apparently part of Perl core modules since 5.6.2
@jtojnar jtojnar requested a review from Ma27 March 29, 2020 00:42
@Ma27 Ma27 merged commit 604b4dd into NixOS:master Mar 29, 2020
@jtojnar jtojnar deleted the hydra-fix-eval branch March 31, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @Ma27