Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.roku: init at v4.1 #83582

Merged
merged 2 commits into from Mar 31, 2020
Merged

Conversation

colemickens
Copy link
Member

Motivation for this change

cc: @Mic92

add pythonPacakges.roku, regenerate home-assistant's component-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

> nixpkgs-review rev HEAD
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-3203a2c6a78ede4baaed3e36da4af3bf4a329cf3/nixpkgs 7dc2439a1be07be4ed6a0e0fb9f6e6e3c97ab126
Preparing worktree (detached HEAD 7dc2439a1be)
Updating files: 100% (21298/21298), done.
HEAD is now at 7dc2439a1be Merge pull request #83515 from snicket2100/firejail-fix
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-3203a2c6a78ede4baaed3e36da4af3bf4a329cf3/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 3203a2c6a78ede4baaed3e36da4af3bf4a329cf3
Auto-merging pkgs/top-level/python-packages.nix
Auto-merging pkgs/servers/home-assistant/component-packages.nix
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-3203a2c6a78ede4baaed3e36da4af3bf4a329cf3/nixpkgs -qaP --xml --out-path --show-trace --meta
2 package added:
python3.7-roku (init at 4.1) python3.8-roku (init at 4.1)

39 package updated:
bcc bpftrace caffe can-isotp chipsec clang-wrapper-with-reexport-hack digimend-unstable digitalbitbox evdi-unstable evdi-unstable flit-build-hook libselinux mba6x_bl musl newlib nix-linter-unstable octave php-couchbase php-couchbase php-pcs php-pcs php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel php-php_excel poezio prl-tools pyblock pyblock python-notify python-notify python2.7-habanero python2.7-handout python2.7-hass-nabucasa qes r8125 r8168

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-3203a2c6a78ede4baaed3e36da4af3bf4a329cf3/build.nix
[1 built, 0.0 MiB DL]
39 package marked as broken and skipped:
clang-sierraHack digitalbitbox linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 muslCross newlibCross nix-linter octave-jit php72Packages-unit.php_excel php72Packages.php_excel php73Packages-unit.php_excel php73Packages.php_excel php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages.couchbase php74Packages.pcs php74Packages.php_excel python27Packages.caffe python27Packages.flitBuildHook python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.notify python37Packages.pyblock python38Packages.libselinux python38Packages.notify python38Packages.poezio python38Packages.pyblock qes

2 package built:
python37Packages.roku python38Packages.roku

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can leave off the v in your commit messages and PR titles, it's understood that it denotes a version. Where as in git, it's not obvious that branch 4.1 means a version number

pkgs/development/python-modules/roku/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/roku/default.nix Outdated Show resolved Hide resolved
pkgs/servers/home-assistant/.gitignore Outdated Show resolved Hide resolved
@Mic92 Mic92 merged commit 5371ea9 into NixOS:master Mar 31, 2020
@colemickens colemickens deleted the nixpkgs-ha-pkgs-roku branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants