Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f7b6f6930e06
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 485fd012b4c8
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 28, 2020

  1. Fix segfault in Remove Spline Point context menu 

    This was incorrectly capturing `r` by reference and using it after it left
its scope. Changed to  capture by value, and also explicitly capture `this`
in case we were accidentally capturing any other scope variables by reference.

Fixes #571
    @Timmmm
    Timmmm authored Mar 28, 2020
    Copy the full SHA
    485fd01 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/mouse.cpp
2 changes: 1 addition & 1 deletion src/mouse.cpp
View file
Original file line number Diff line number Diff line change
@@ -647,7 +647,7 @@ void GraphicsWindow::MouseRightUp(double x, double y) {
int index = r->IndexOfPoint(gs.point[0]);
if((r->type == Request::Type::CUBIC && (index > 1 && index < r->extraPoints + 2)) ||
r->type == Request::Type::CUBIC_PERIODIC) {
menu->AddItem(_("Remove Spline Point"), [&]() {
menu->AddItem(_("Remove Spline Point"), [this, r]() {
int index = r->IndexOfPoint(gs.point[0]);
ssassert(r->extraPoints != 0,
"Expected a bezier with interior control points");