Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-kitty-navigator: init at 2019-11-04 #79193

Merged
merged 1 commit into from Mar 28, 2020
Merged

vimPlugins.vim-kitty-navigator: init at 2019-11-04 #79193

merged 1 commit into from Mar 28, 2020

Conversation

equirosa
Copy link
Contributor

@equirosa equirosa commented Feb 4, 2020

Motivation for this change

Add vim plugin: vim-kitty-navigator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timokau
timokau approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but due to the high potential for conflicts in vim plugin changes this will have to wait until #83119 and #69130 are resolved. If I forget, please remind me to merge this.

@timokau
Copy link
Member

timokau commented Mar 27, 2020

Those PRs have been merged, so this should be good to go after a rebase.

@equirosa equirosa force-pushed the vimPlugins.vim-kitty-navigator branch from d02fb1c to aed79fb Compare March 28, 2020 01:19
@equirosa
Copy link
Contributor Author

Those PRs have been merged, so this should be good to go after a rebase.

Done! 😄

timokau
timokau approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit f076ece into NixOS:master Mar 28, 2020
@equirosa equirosa deleted the vimPlugins.vim-kitty-navigator branch September 27, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@equirosa @timokau