Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propragate darwin go #83472

Merged
merged 2 commits into from Mar 28, 2020
Merged

Propragate darwin go #83472

merged 2 commits into from Mar 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 27, 2020

Motivation for this change

Better fix instead of #83099

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
go: propagate target build dependencies correctly
0bba747 
When using strict deps we have to use depsTargetTargetPropagated
as go is added as a nativeBuildInputs to our build.
@Mic92
Revert "Merge pull request NixOS#83099 from marsam/fix-buildGoModule-…
066db11 
…packages-darwin"

This reverts commit 4e6bf03, reversing
changes made to afd997a.

Instead we propagate those frameworks from the compiler again
@Mic92 Mic92 requested a review from marsam March 27, 2020 07:35
@Mic92
Copy link
Member Author

Mic92 commented Mar 27, 2020

@GrahamcOfBorg build geoipupdate

@Mic92 Mic92 requested review from LnL7 and Ericson2314 March 27, 2020 07:36
Ericson2314
Ericson2314 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@Mic92
Copy link
Member Author

Mic92 commented Mar 28, 2020

@GrahamcOfBorg build hugo

@Mic92 Mic92 merged commit 774ddeb into NixOS:master Mar 28, 2020
@Mic92 Mic92 deleted the propragate-darwin-go branch March 28, 2020 06:58
@zowoq zowoq mentioned this pull request Aug 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@marsam marsam Awaiting requested review from marsam

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: golang 8.has: documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Ericson2314