Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] torchPackages, torch-repl: remove #83567

Merged
merged 1 commit into from Mar 28, 2020
Merged

[20.03] torchPackages, torch-repl: remove #83567

merged 1 commit into from Mar 28, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Mar 28, 2020

Motivation for this change

Backport of #81173.

CC @NixOS/nixos-release-managers
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto @nh2
torchPackages, torch-repl: remove
18c0784 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.

(cherry picked from commit 05b6836)
@nh2 nh2 requested review from Mic92 and teto March 28, 2020 02:20
@worldofpeace
Copy link
Contributor

We really should have a throw in aliases.nix. Would love to have a throws.nix eventually.

@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
@nh2
Copy link
Contributor Author

nh2 commented Mar 28, 2020

We really should have a throw in aliases.nix. Would love to have a throws.nix eventually.

I'm not familiar yet with how that works, but I have asked in #83568 (comment).

@bhipple
Copy link
Contributor

bhipple commented Mar 28, 2020

Torch it! 🔥

@worldofpeace worldofpeace merged commit cdf5eca into NixOS:release-20.03 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @worldofpeace @bhipple @teto