Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: remove torch and related packages #83568

Merged
merged 1 commit into from Mar 28, 2020
Merged

treewide: remove torch and related packages #83568

merged 1 commit into from Mar 28, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 28, 2020 •
edited

See #71888 for details.

CC @NixOS/nixos-release-managers @nh2 @teto

ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

@GrahamcOfBorg eval

bhipple
bhipple commented Mar 28, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -23714,7 +23699,7 @@ in
multimc = libsForQt5.callPackage ../games/multimc { };

inherit (callPackages ../games/minetest {
inherit (darwin) libiconv;
inherit (darwin) libiconv;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, my emacs replaced the tab character someone inserted into this file with the correct number of spaces.

bhipple
bhipple commented Mar 28, 2020
View reviewed changes
pkgs/development/libraries/torch/default.nix
];

src = fetchgit {
url = "https://github.com/torch/distro";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're running version 0.0pre20160820, which hasn't built in a long time, and upstream https://github.com/torch/distro/blob/master/README.md says, as of 3 years ago:

NOTE: Torch is not actively developed anymore and is in maintenance mode.

@nh2
Copy link
Contributor

nh2 commented Mar 28, 2020

@nh2

Btw I know nothing about torch, on #83567 I just cherry-picked @teto's cleanup.

@bhipple on #83567 (comment) @worldofpeace said:

We really should have a throw in aliases.nix. Would love to have a throws.nix eventually.

Do you know how to do that? If yes, could you do it for these packages?

@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
@bhipple
Copy link
Contributor Author

bhipple commented Mar 28, 2020

I think the idea is to check in something in the top-level aliases.nix, like this:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L51

So that if an unsuspecting user goes to try to do something like nix-build -A torch, they will get the alias telling them it was deleted rather than an attribute not found error.

Is that right @worldofpeace? In this particular case I think we'd be fine with or without the aliases, since it's been broken for a long time and upstream died out years ago by the looks of it, so there probably won't be many users trying it out.

@worldofpeace
Copy link
Contributor

I think the idea is to check in something in the top-level aliases.nix, like this:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/aliases.nix#L51

So that if an unsuspecting user goes to try to do something like nix-build -A torch, they will get the alias telling them it was deleted rather than an attribute not found error.

Is that right @worldofpeace? In this particular case I think we'd be fine with or without the aliases, since it's been broken for a long time and upstream died out years ago by the looks of it, so there probably won't be many users trying it out.

Yes, that is spot on. Considering it has died out for years a silent removal could be ok. But in a general sense, the silent removal of anything usually upsets end users.

@worldofpeace worldofpeace merged commit 2b1f4f3 into NixOS:master Mar 28, 2020
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
a80ed9f 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568
@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
4a3f221 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
@bhipple bhipple deleted the rm/torch branch June 2, 2020 22:08
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@bhipple @stigok
aliases.nix: add aliases for removed torch packages
bb3aa84 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @nh2 @worldofpeace