Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest: 5.3.5 -> 5.4.1 #83675

Closed
wants to merge 3 commits into from
Closed

pythonPackages.pytest: 5.3.5 -> 5.4.1 #83675

wants to merge 3 commits into from

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 29, 2020 •
edited

Motivation for this change

Making pytest work in Python 3.9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python27Packages.pytest python37Packages.pytest python38Packages.pytest python39Packages.pytest

@FRidh
Copy link
Member

FRidh commented Mar 29, 2020

The Python packages set needs to be tested with this change.

@FRidh FRidh self-assigned this Mar 29, 2020
@KamilaBorowska
Copy link
Member Author

Probably should be staging.

@KamilaBorowska KamilaBorowska changed the base branch from master to staging March 29, 2020 12:02
@FRidh
Copy link
Member

FRidh commented Mar 29, 2020

Included in #83676

@FRidh FRidh closed this Mar 29, 2020
@FRidh FRidh reopened this Mar 30, 2020
@FRidh
Copy link
Member

FRidh commented Mar 30, 2020

Removed from #83676 due to too much breakage (sqlalchemy).

@FRidh FRidh added this to Needs review in Staging Apr 3, 2020
@grahamc
Copy link
Member

grahamc commented Apr 6, 2020

@GrahamcOfBorg eval

@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Apr 6, 2020 •
edited

This doesn't work, I'm experimenting currently. Currently this pull request breaks too much.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python3Packages.sqlalchemy

@KamilaBorowska KamilaBorowska changed the title pythonPackages.pytest: 5.3.5 -> 5.4.1 WIP: pythonPackages.pytest: 5.3.5 -> 5.4.1 Apr 6, 2020
@KamilaBorowska KamilaBorowska changed the title WIP: pythonPackages.pytest: 5.3.5 -> 5.4.1 pythonPackages.pytest: 5.3.5 -> 5.4.1 Apr 6, 2020
Staging automation moved this from Needs review to Done Apr 6, 2020
@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Apr 6, 2020 •
edited

Closing until it will become usable enough (unfortunately GitHub doesn't allow marking a pull request as a draft).

@jonringer
Copy link
Contributor

Closing until it will become usable enough (unfortunately GitHub doesn't allow marking a pull request as a draft).

It does, but only when you first create it. The convention currently is to change the title of the PR to: [WIP] ...

@drewrisinger
Copy link
Contributor

Closing until it will become usable enough (unfortunately GitHub doesn't allow marking a pull request as a draft).

It actually does, it just is kinda hidden. On the right sidebar, there's a "Convert to draft" or similar button, in small print.

@KamilaBorowska
Copy link
Member Author

@drewrisinger This functionality did not exist back when I closed this pull request, I believe it was added a few days afterwards.

@jonringer
Copy link
Contributor

Thats correct, being able to convert to draft was a semi-recent addition

@drewrisinger
Copy link
Contributor

Thanks, I stand corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@lovek323 lovek323 Awaiting requested review from lovek323

@lsix lsix Awaiting requested review from lsix

@domenkozar domenkozar Awaiting requested review from domenkozar

@madjar madjar Awaiting requested review from madjar

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KamilaBorowska @FRidh @grahamc @jonringer @drewrisinger