Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ftputil: fix build #83672

Merged
merged 1 commit into from Mar 29, 2020
Merged

pythonPackages.ftputil: fix build #83672

merged 1 commit into from Mar 29, 2020

Conversation

KamilaBorowska
Copy link
Member

Some tests assume execution before 2020.

@GrahamcOfBorg build python27Packages.ftputil python37Packages.ftputil python38Packages.ftputil

(python39Packages.ftputil doesn't build because of pytest)

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
pythonPackages.ftputil: fix build
c7c9719 
Some tests assume execution before 2020.
@KamilaBorowska KamilaBorowska force-pushed the ftputil-disable-tests-assuming-execution-before-2020 branch from 3e3f6c9 to c7c9719 Compare March 29, 2020 11:25
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python27Packages.ftputil python37Packages.ftputil python38Packages.ftputil

@FRidh FRidh merged commit cfb4357 into NixOS:master Mar 29, 2020
@KamilaBorowska KamilaBorowska mentioned this pull request Mar 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @FRidh