Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curaLulzbot: Fix build breakage around OpenMP compatibility #83604

Merged
merged 1 commit into from Mar 31, 2020

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

Fix compatibility with OpenMP preventing successful build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@charles-dyfis-net
Copy link
Contributor Author

A backport is going to be needed for #80379

@charles-dyfis-net
Copy link
Contributor Author

charles-dyfis-net commented Mar 29, 2020

Looking for an upstream fix --

The immediate cause: GCC 9, as documented in https://gcc.gnu.org/gcc-9/porting_to.html#ompdatasharing, is enforcing OpenMP 5.0 (vs 3.1) semantics. This confirms firstprivate (or, as an alternative, dropping default(none)) as equivalent to legacy behavior.

Upstream Cura filed this as Ultimaker/CuraEngine#984. Their final fix is a bit more involved as it attempts to retain compatibility with older versions of gcc; not sure if that's a goal here.

@Mic92 Mic92 merged commit bfe1e17 into NixOS:master Mar 31, 2020
@Mic92
Copy link
Member

Mic92 commented Mar 31, 2020

Do we need a backport?

@charles-dyfis-net
Copy link
Contributor Author

Do we need a backport?

Yes; this is broken on the release branch, as you can see at https://hydra.nixos.org/build/115536799

What's the process for that -- do I file a separate PR? (It's a clean cherry-pick).

@nh2
Copy link
Contributor

nh2 commented Mar 31, 2020

do I file a separate PR? (It's a clean cherry-pick).

@charles-dyfis-net Yes, separate PR against release-20.03, ideally with a [20.03] PR in the title, and using git cherry-pick -x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants