Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null values in attrsets option examples #371

Merged
merged 1 commit into from Apr 14, 2020
Merged

Handle null values in attrsets option examples #371

merged 1 commit into from Apr 14, 2020

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Mar 28, 2020

Fix #370

@garbas garbas added this to Confirmed in TODO Mar 29, 2020
@zarelit
Copy link
Member Author

zarelit commented Apr 5, 2020

@samueldr @garbas The issue arise only for options that have all of these together:

  • non literal example
  • example is an attrset
  • the value of a key is null

the patch just adds this edge case to the needIndentation function. I've built and tested the patch offline

@garbas garbas requested a review from samueldr April 6, 2020 23:35
@garbas garbas merged commit 0713560 into NixOS:master Apr 14, 2020
@garbas
Copy link
Member

garbas commented Apr 14, 2020

@zarelit thx!

@garbas garbas moved this from Confirmed to Done in TODO Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
None yet
Projects
TODO
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

options: clicking on environment.shellAliases does not show documentation
2 participants
@zarelit @garbas