Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] mongodb: update #83628

Merged
merged 11 commits into from
Apr 3, 2020
Merged

[20.03] mongodb: update #83628

merged 11 commits into from
Apr 3, 2020
+254 −88

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 28, 2020

Motivation for this change

Backport PR for #40082 and #83617.

(@worldofpeace I may be wrong, but did you mention that you'd prefer to only backport mongodb 3.4.24? In that case I'd remove 3.6/4.0 from this PR. I just added all of it for now as it was rather tight coupled due to the package split :))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

jarjee and others added 10 commits March 28, 2020 21:28
@jarjee @Ma27
mongodb: 3.4.10 -> 4.0.4
ac23e50 
fix: Adding libtool to allow darwin compiles

Libtool seems to be required for mongodb to compile on darwin.

fix: Marking MongoDB as broken on aarch64

fix: Adding libtools to the pkg imports

Update mongodb to 4.0.4

(cherry picked from commit e9bec1a)
@jarjee @Ma27
mongodb: split packages to expose 3.4, 3.6 and 4.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
54d2944 
(cherry picked from commit 97c4dff)
@jarjee @Ma27
mongodb: 3.4.20 -> 3.4.22, 3.6.12 -> 3.6.13, 4.0.9 -> 4.0.11
83d7124 
(cherry picked from commit 165d8bd)
@jarjee @Ma27
nixos/tests/mongodb: test against mongodb versions 3.4, 3.6, 4.0
2cba56e 
Now has tests for 3.4, 3.6, 4.0. Has some duplication, but it appears to
work on my machine.

(cherry picked from commit 44641ed)
@jarjee @Ma27
mongodb-4_0: 4.0.11 -> 4.0.12
ef9bd8e 
(cherry picked from commit de69821)
@Ma27
mongodb: 3.4.22 -> 3.4.24 & fix ssl
00d69b8 
Reverts previous ssl fix commit and updates the mongodb version which fixes the ssl compile problem on darwin.

(cherry picked from commit c2eee6e)
@Ma27
mongodb: builds on aarch64 as well
56bfb0d 
(cherry picked from commit 80e6da7)
@Ma27
nixos/tests/mongodb: rewrite with python
07fb019 
perl-based VM tests are deprecated.

(cherry picked from commit 2934f04)
@Ma27
nixos/release-notes: mention mongodb update
7cf4906 
(cherry picked from commit b65ff5d)
@Ma27
nixos/release-notes: mention that mongodb is unfree now
cd36c1d 
(cherry picked from commit 2712152)
@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 28, 2020
@Ma27 Ma27 added this to the 20.03 milestone Mar 28, 2020
@Ma27 Ma27 requested a review from alyssais as a code owner March 28, 2020 22:45
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: clean-up 8.has: package (new) This PR adds a new package labels Mar 28, 2020
@worldofpeace
Copy link
Contributor

(@worldofpeace I may be wrong, but did you mention that you'd prefer to only backport mongodb 3.4.24? In that case I'd remove 3.6/4.0 from this PR. I just added all of it for now as it was rather tight coupled due to the package split :))

I did mention to backport the most minimal upgrade because we are already frozen.
And that's just to avoid additional fixes because the audit for 3.4.10 -> 4.0.4 is much bigger than what is actually minimally required which you mentioned would be 3.4.24.
But I'm open to second opinions on this because I don't know the semantics of the versioning here, or know anything about mongodb (I what would be a good practical application of best practices)

@worldofpeace
Copy link
Contributor

@Ma27 I see the default is 3.4.x, but backported newer versions. I don't see a problem with that.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/10

@worldofpeace worldofpeace added the 1.severity: blocker This is preventing another PR or issue from being completed label Apr 3, 2020
worldofpeace
worldofpeace approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this being backported.

@Ma27
Copy link
Member Author

Ma27 commented Apr 3, 2020 •
edited by worldofpeace
Loading

In the go/no-go meeting it has been decided that this is good to go and Hydra shouldn't build (for now) unfree code.

@Ma27 Ma27 merged commit 0abd4fd into NixOS:release-20.03 Apr 3, 2020
@Ma27 Ma27 deleted the mongodb-20.03 branch April 3, 2020 19:49
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-03-markhor/6495/16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@disassembler disassembler

@aanderse aanderse

@alyssais alyssais

@offlinehacker offlinehacker

@bluescreen303 bluescreen303

@cstrahan cstrahan

Assignees
No one assigned
Labels
1.severity: blocker This is preventing another PR or issue from being completed 1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @worldofpeace @nixos-discourse @jarjee