Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault in Remove Spline Point context menu #572

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Fix segfault in Remove Spline Point context menu #572

merged 1 commit into from
Mar 28, 2020
+1 −1

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Mar 28, 2020

This was incorrectly capturing r by reference and using it after it left its scope. Changed to capture by value, and also explicitly capture this in case we were accidentally capturing any other scope variables by reference.

Fixes #571

@Timmmm
Fix segfault in Remove Spline Point context menu
49ae6a0 
This was incorrectly capturing `r` by reference and using it after it left its scope. Changed to capture by value, and also explicitly capture `this` in case we were accidentally capturing any other scope variables by reference.

Fixes solvespace#571
@whitequark whitequark merged commit 485fd01 into solvespace:master Mar 28, 2020
@Timmmm Timmmm deleted the patch-1 branch March 28, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault when removing bezier spline point
2 participants
@Timmmm @whitequark