Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] backport brave: 1.5.112 -> 1.5.115 #83641

Merged

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Mar 29, 2020

Update the checkum and the version

(cherry picked from commit fa5fc49)
Reason: Browser must be kept up-to-date

Motivation for this change

Keep the browser up-to-date for release 20.03

Backport PR #83343

Things done

Update checksum and version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Update the checkum and the version

(cherry picked from commit fa5fc49)
Reason: Browser must be kept up-to-date
@JeffLabonte JeffLabonte changed the title brave: 1.5.112 -> 1.5.115 [20.03] backport brave: 1.5.112 -> 1.5.115 Mar 29, 2020
@ofborg ofborg bot requested review from rht and uskudnik March 29, 2020 03:34
@rht
Copy link
Member

rht commented Mar 29, 2020

LGTM

@FRidh FRidh merged commit 2d0d227 into NixOS:release-20.03 Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants