util: Don't check if process.stdin is None unless stdin_string is passed #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling subprocess.Popen passing anything except subprocess.PIPE as stdin the results stdin attribute is None. If a file descriptor was passed as stdin we don't want to run this check.
|
I wonder how tricky it would be to write a test for this, what do you think? |
adisbladis
force-pushed
the
util-fd-fix
branch
2 times, most recently
from
fc9b190
to
8d2f8ae
Compare
|
This test https://github.com/NixOS/nixops/pull/1268/files#diff-f622ee648d48b94128d5bbef35efceceR23 would have caught the issue. Manually verified by reverting the fixup commit. |
|
test coverage 📈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling subprocess.Popen passing anything except subprocess.PIPE as stdin the results stdin attribute is None.
If a file descriptor was passed as stdin we don't want to run this check.