Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: use node2nix from git #83475

Merged
merged 1 commit into from Mar 28, 2020
Merged

nodePackages: use node2nix from git #83475

merged 1 commit into from Mar 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 referenced this pull request Mar 27, 2020
@Mic92
nodePackages: fix broken update script
216c58a 
The computed path was wrong and references within the file where
wrong as well due to the temporary directory.
@rileyinman
Copy link
Contributor

Is there a reason this doesn't build versions 10 and 12?

@Mic92 Mic92 merged commit 375d1fa into NixOS:master Mar 28, 2020
@Mic92 Mic92 deleted the node2nix branch March 28, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @rileyinman