Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: add bcmap, mp4 and webm in nginx configuration #83653

Merged
merged 1 commit into from Mar 29, 2020
Merged

nixos/nextcloud: add bcmap, mp4 and webm in nginx configuration #83653

merged 1 commit into from Mar 29, 2020

Conversation

nlewo
Copy link
Member

@nlewo nlewo commented Mar 29, 2020

This is used by the firstrunwizard and has been added in the nginx
configuration documentation of the latest
manual (https://github.com/nextcloud/documentation/blob/cda627b7c8896f3bac8bfde420c0c8b5d1806190/admin_manual/installation/nginx.rst).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo nlewo added this to the 20.03 milestone Mar 29, 2020
@nlewo
Copy link
Member Author

nlewo commented Mar 29, 2020

@GrahamcOfBorg test nextcloud

@Ma27 Ma27 merged commit d25b558 into NixOS:master Mar 29, 2020
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 29, 2020
@Ma27
Copy link
Member

Ma27 commented Mar 29, 2020

Thanks! Also backported as 4b5e5fc.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlewo @Ma27