Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic.python3: fix build #83663

Merged
merged 1 commit into from Mar 30, 2020
Merged

pkgsStatic.python3: fix build #83663

merged 1 commit into from Mar 30, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Mar 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from adisbladis March 29, 2020 10:04
@FRidh FRidh added this to Needs review in Static builds Mar 29, 2020
@FRidh
Copy link
Member Author

FRidh commented Mar 29, 2020

Note import struct is broken though. pip for example does not function because of this.

@FRidh
Copy link
Member Author

FRidh commented Mar 30, 2020

Also need to add a dev output to get rid of retained references, but that's for later.

@FRidh FRidh merged commit c392d70 into NixOS:master Mar 30, 2020
@FRidh FRidh deleted the staticpython branch March 30, 2020 15:06
@cdepillabout cdepillabout moved this from Needs review to Done in Static builds Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Static builds
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh