Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for simple validations #112

Merged
merged 6 commits into from Mar 29, 2020

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Mar 29, 2020

We can expand for more serious work later.

This

  • Validates all nix files are parsable.
  • Builds the documentation.
  • Instantiates everything from release.nix.

The built documentation is also available as an artifact in the checks, as a zip, look at the top right corner. Though, not as useful as if it was directly consumable and uploaded somewhere :(.


This also fixes two semi-related issues.

  • Something with the nix-env based eval triggered a behaviour from the system eval that didn't work the same way as on Hydra. This is fixed by having the "none" system type.
  • The Pinephone change had a broken eval! This PR would have shown that easily!

I'm not sure why it doesn't matter on Hydra, and when using `nix-build`,
but it does matter for `nix-env`.
The "default" output was missing.
This is to be used with `nix-env` in a CI situation to list everything
from release.nix.
@samueldr samueldr merged commit 8fd6adc into NixOS:master Mar 29, 2020
@samueldr samueldr deleted the feature/gh-actions branch April 7, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant