Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins.vim-pico8-syntax: init at 2016-10-30 #83588

Merged
merged 1 commit into from Apr 1, 2020
Merged

vimPlugins.vim-pico8-syntax: init at 2016-10-30 #83588

merged 1 commit into from Apr 1, 2020

Conversation

evenbrenden
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • Ubuntu 18.04
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryneeverett
ryneeverett suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ryneeverett ryneeverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine but commit message should be vimPlugins.vim-pico8-syntax: init at 2016-10-30

@evenbrenden evenbrenden changed the title vim-plugins: add vim-pico8-syntax vimPlugins.vim-pico8-syntax: init at 2016-10-30 Mar 30, 2020
timokau
timokau approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Blocked by the ofBorg issue (something is broken on master). Ping me again tomorrow if I haven't merged this by then.

@timokau
Copy link
Member

timokau commented Mar 31, 2020

@GrahamcOfBorg eval

@timokau timokau merged commit bd12256 into NixOS:master Apr 1, 2020
@evenbrenden evenbrenden deleted the vim-pico8-syntax branch April 1, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryneeverett ryneeverett ryneeverett requested changes

@timokau timokau timokau approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evenbrenden @timokau @ryneeverett