Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-cash: 4.0.11 -> 4.0.14 #83587

Merged
merged 1 commit into from Mar 28, 2020
Merged

electron-cash: 4.0.11 -> 4.0.14 #83587

merged 1 commit into from Mar 28, 2020

Conversation

jluttine
Copy link
Member

Motivation for this change

Upgrade Electron Cash wallet:

  • Bump the version number.
  • Add an optional library to path so that elliptic curve cryptography is more efficient.
  • Add a new dependency.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jluttine
Copy link
Member Author

cc maintainers @Lassulus and @nyanloutre

@ofborg ofborg bot requested review from Lassulus and nyanloutre March 28, 2020 12:29
@nyanloutre
Copy link
Member

It's OK for me

@Lassulus Lassulus merged commit f576221 into NixOS:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@nyanloutre nyanloutre Awaiting requested review from nyanloutre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jluttine @nyanloutre @Lassulus