Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.ftputil: fix build #83682

Merged
merged 1 commit into from Mar 29, 2020
Merged

[20.03] pythonPackages.ftputil: fix build #83682

merged 1 commit into from Mar 29, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Mar 29, 2020 •
edited

Motivation for this change

ZHF: #80379, see #83672 for original PR

@NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
pythonPackages.ftputil: fix build
ce667d5 
Some tests assume execution before 2020.

(cherry picked from commit cfb4357)
@KamilaBorowska KamilaBorowska changed the title pythonPackages.ftputil: fix build [20.03] pythonPackages.ftputil: fix build Mar 29, 2020
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python27Packages.ftputil python37Packages.ftputil python38Packages.ftputil

bhipple
bhipple approved these changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 83682 1

3 package built: - python27Packages.ftputil - python37Packages.ftputil - python38Packages.ftputil

@bhipple bhipple merged commit 87d71b4 into NixOS:release-20.03 Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @bhipple