Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: custom wine installations require libkrb5 #83645

Merged
merged 1 commit into from Mar 31, 2020
Merged

lutris: custom wine installations require libkrb5 #83645

merged 1 commit into from Mar 31, 2020

Conversation

RohanHart
Copy link
Contributor

Motivation for this change

Currently all custom wine runtimes installed by Lutris fail to start with the error: symbol k5_os_mutex_destroy version krb5support_0_MIT not defined in file libkrb5support.so.0

Things done

Add the libkrb5 dependency to the FHS environment

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RohanHart
lutris: custom wine installations require libkrb5
1b56b7f 
fixes the error: symbol k5_os_mutex_destroy version krb5support_0_MIT not defined in file libkrb5support.so.0
@RohanHart RohanHart mentioned this pull request Mar 29, 2020
Merged
10 tasks
jonringer
jonringer approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83645 1

2 packages built: - lutris - lutris-free

@jonringer jonringer merged commit 41fe7db into NixOS:master Mar 31, 2020
@RohanHart RohanHart deleted the lutris/wine-depends-on-libkrb5 branch March 31, 2020 03:34
@Emantor Emantor mentioned this pull request Apr 1, 2020
Closed
@IvarWithoutBones IvarWithoutBones mentioned this pull request Aug 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RohanHart @jonringer