haskellPackages.hoggl: fix build #82984
Conversation
Also, add myself to the maintainers section for Haskell modules coming from Hackage.
icepeak: init at 0.7.2
This update was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@a155538.
This update was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@af60c8c.
This update was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@b0c1d8f.
- tasty-tap's tests were failing. In NixOS#71017 a patch generated from a PR was applied to fix this. - That PR has now been merged into tasty-tap and was released with version 0.1.0. - tasty-tap is now at version 0.1.0 in nixpkgs and so the patch fails to apply, breaking the build. - Removed the patch and removed tasty-tap from list of broken packages.
- "ekg-core" and "ekg-prometheus-adapter" are no longer broken. Removed them from broken packages list.
This update was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@02fb2c3.
…etheus-adapter ekg-core,ekg-prometheus-adapter: unmark broken
…move-patch tasty-tap: fix failing build
- prometheus no longer needs to be jailbroken, removing 'doJailbreak'. Jailbreaking was added in NixOS#70956 to overcome issue bitnomial/prometheus#34. - This issue has since been fixed and so jailbreaking is no longer necessary.
…ont-jailbreak Feature/prometheus dont jailbreak
This update was generated by hackage2nix v2.15.1 from Hackage revision commercialhaskell/all-cabal-hashes@ba7eac7.
|
@pschuprikov Can you see if instead upstream will make a release that fixes this? |
| @@ -1485,4 +1485,13 @@ self: super: { | |||
| sha256 = "097wqn8hxsr50b9mhndg5pjim5jma2ym4ylpibakmmb5m98n17zp"; | |||
| }); | |||
|
|
|||
| # hackage version does not support newer servant api | |||
| hoggl = overrideSrc super.hoggl { | |||
| src = pkgs.fetchFromGitHub { | |||
There was a problem hiding this comment.
Overriding src with a specific github revision is pretty ugly. The danger we face doing this is that we'll keep shipping the unofficial version even after a new release has been made on Hackage. It would be much better to (a) lobby upstream to release a new version or (b) apply a patch to the existing version so that the build will fail if a new version comes out that has that patch applied already. Then we'll notice that the patch can be dropped.
There was a problem hiding this comment.
Oh, yes, thanks! I totally forgot about the appendPatch/fetchpatch option. I'm trying to do (a) in the mean time markus1189/hoggl#12
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
b6d2377
to
1b2b886
Compare
|
Will you update this PR to get it merged? There are a couple of conflicts. You should probably re-base to the current version of |
|
Yes, will do today. |
|
Since things have started to move with the new hackage version, I guess I can close the PR. |
Motivation for this change
hogglwas brokenThings done
Use GitHub upstream
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)