wolf-spectrum: init at 1.0.0 #83579
wolf-spectrum: init at 1.0.0 #83579
Conversation
| ''; | ||
|
|
||
| meta = with pkgs.stdenv.lib; { | ||
| homepage = "https://pdesaulniers.github.io/wolf-shaper/"; |
There was a problem hiding this comment.
You might wanna check the homepage, description and maintainer.
There was a problem hiding this comment.
Whops, sorry 'bout that.
matthiasbeyer
force-pushed
the
add-wolf-spectrum
branch
from
983ded6
to
c073336
Compare
|
Works for me! |
| cp -r bin/wolf-spectrum.lv2 $out/lib/lv2/ | ||
| #cp -r bin/wolf-spectrum-dssi* $out/lib/dssi/ | ||
| cp -r bin/wolf-spectrum-vst.so $out/lib/vst/ | ||
| cp -r bin/wolf-spectrum $out/bin/ |
There was a problem hiding this comment.
is there anyway to check that these are the correct install paths? Also, i don't see any headers being installed
There was a problem hiding this comment.
Why would you need any headers?
What do you mean by correct install paths? I can tell you that this plugin worked in ardour5 with this setup... not sure what you want. 😄
There was a problem hiding this comment.
I guess that's what i was looking for
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
still important to me |
stale
bot
removed
the
2.status: stale
|
@matthiasbeyer there is a merge conflict here. |
matthiasbeyer
force-pushed
the
add-wolf-spectrum
branch
from
6a5eeec
to
92239fa
Compare
|
Result of 1 package built:
Don't know how to properly test this, but I ran the binary and it runs (with error because I probably doesn't have a proper JACK setup). |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
|
||
| installPhase = '' | ||
| mkdir -p $out/lib/lv2 | ||
| #mkdir -p $out/lib/dssi |
There was a problem hiding this comment.
Randomly commented-out stuff, and this installPhase in general: Please add some comments that describe what's (not) copied and why.
I suspect from "BUILD_DSSI=false" above that it doesn't build and you might want it to build in the future -- a comment on "BUILD_DSSI=false" might be excellent for that (you may also want to make the makeFlags above multi-line to best be able to place your comment).
matthiasbeyer
force-pushed
the
add-wolf-spectrum
branch
from
0e2e9a0
to
9c1599c
Compare
| mkdir -p $out/lib/vst | ||
| mkdir -p $out/bin/ | ||
| cp -r bin/wolf-spectrum.lv2 $out/lib/lv2/ | ||
| #cp -r bin/wolf-spectrum-dssi* $out/lib/dssi/ |
There was a problem hiding this comment.
| #cp -r bin/wolf-spectrum-dssi* $out/lib/dssi/ |
There was a problem hiding this comment.
You forgot to remove the comment.
| mkdir -p $out/lib/lv2 | ||
| #mkdir -p $out/lib/dssi | ||
| mkdir -p $out/lib/vst | ||
| mkdir -p $out/bin/ |
There was a problem hiding this comment.
| mkdir -p $out/lib/lv2 | |
| #mkdir -p $out/lib/dssi | |
| mkdir -p $out/lib/vst | |
| mkdir -p $out/bin/ | |
| mkdir -p $out/lib/lv2 $out/lib/vst $out/bin/ |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
matthiasbeyer
force-pushed
the
add-wolf-spectrum
branch
from
24f0bd9
to
4f36b60
Compare
| description = "Real-time 2D spectrogram plugin (LV2, VST and Jack)"; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = [ maintainers.matthiasbeyer ]; | ||
| platforms = [ "i686-linux" "x86_64-linux" ]; |
There was a problem hiding this comment.
| platforms = [ "i686-linux" "x86_64-linux" ]; | |
| platforms = platforms.linux; |
| mkdir -p $out/lib/vst | ||
| mkdir -p $out/bin/ | ||
| cp -r bin/wolf-spectrum.lv2 $out/lib/lv2/ | ||
| #cp -r bin/wolf-spectrum-dssi* $out/lib/dssi/ |
There was a problem hiding this comment.
You forgot to remove the comment.
Thanks for @mrVanDalo as this is only copy-paste from here: https://git.ingolf-wagner.de/palo/nixos-config/src/master/pkgs/wolf-spectrum/default.nix
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)