Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_14: 1.14 -> 1.14.1 #83689

Merged
merged 1 commit into from Apr 2, 2020
Merged

go_1_14: 1.14 -> 1.14.1 #83689

merged 1 commit into from Apr 2, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 29, 2020 •
edited

This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor Author

flokli commented Mar 29, 2020

This should be backported to 20.03 as well.

@flokli flokli mentioned this pull request Mar 29, 2020
Closed
@flokli
Copy link
Contributor Author

flokli commented Mar 29, 2020

@GrahamcOfBorg build buildkite-agent terraform-full

@Mic92
Copy link
Member

Mic92 commented Mar 29, 2020

If you merge this to master we can as well cherry-pick ff2ea91

@Mic92 Mic92 mentioned this pull request Mar 29, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from kalbasit and cstrahan March 29, 2020 14:06
@flokli
Copy link
Contributor Author

flokli commented Mar 29, 2020

It seems terranix is currently broken - it refers to a non-existing rev, which is why terraform-full fails to build in CI (but the other providers build, and I hope there's no major changes in that minor release).

I can cherry-pick ff2ea91 into this PR, but can also retarget to staging - your call.

Obviously, ff2ea91 shouldn't go to 20.03, though ;-)

@Mic92
Copy link
Member

Mic92 commented Apr 2, 2020

It seems terranix is currently broken - it refers to a non-existing rev, which is why terraform-full fails to build in CI (but the other providers build, and I hope there's no major changes in that minor release).

I can cherry-pick ff2ea91 into this PR, but can also retarget to staging - your call.

Obviously, ff2ea91 shouldn't go to 20.03, though ;-)

is terranix in nixpkgs?

@flokli
Copy link
Contributor Author

flokli commented Apr 2, 2020

No, I screwed up, and had that (broken) in my local overlay - figuring this out was quite some fun while working on #83279 :-D

@Mic92
Copy link
Member

Mic92 commented Apr 2, 2020

@GrahamcOfBorg build docker

@Mic92
Copy link
Member

Mic92 commented Apr 2, 2020

@GrahamcOfBorg build direnv

@flokli
go_1_14: 1.14 -> 1.14.1
da2146d 
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.
@flokli flokli changed the base branch from master to staging April 2, 2020 18:07
@Mic92 Mic92 merged commit d7f86b3 into NixOS:staging Apr 2, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 2, 2020

staging backport: 3b38319

@flokli flokli deleted the go-1.14.1 branch April 2, 2020 20:01
@flokli
Copy link
Contributor Author

flokli commented Apr 2, 2020

^ 3b38319 was the staging-20.03 backport.

@doronbehar doronbehar mentioned this pull request Apr 3, 2020
Closed
@knl knl mentioned this pull request Apr 6, 2020
Merged
10 tasks
dhess pushed a commit to hackworthltd/hacknix that referenced this pull request Apr 8, 2020
Override nixpkgs-unstable until Go issue is fixed.
91a959d 
See NixOS/nixpkgs#83689
@Frostman Frostman mentioned this pull request Apr 8, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@Frostman Frostman Awaiting requested review from Frostman

@kalbasit kalbasit Awaiting requested review from kalbasit kalbasit is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

@andir andir Awaiting requested review from andir

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: golang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Mic92