Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: custom wine installations require libkrb5. Backport #83645 #83655

Merged
merged 1 commit into from Apr 3, 2020
Merged

lutris: custom wine installations require libkrb5. Backport #83645 #83655

merged 1 commit into from Apr 3, 2020

Conversation

RohanHart
Copy link
Contributor

Motivation for this change

Currently all custom wine runtimes installed by Lutris fail to start with the error: symbol k5_os_mutex_destroy version krb5support_0_MIT not defined in file libkrb5support.so.0

Things done

backport #83645 as this error was discovered in 20.03

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RohanHart RohanHart changed the title backport #83645 lutris: custom wine installations require libkrb5. Backport #83645 Mar 29, 2020
jonringer
jonringer reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When backporting changes, please follow https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes.

Namely, you should be doing git cherry-pick -x <rev> from a commit that has already landed in master. If the branches have diverged, you may alter the commit or add another commit to ensure that the package is able to still evaluate and build

@RohanHart
Copy link
Contributor Author

Thanks for pointing that out - I'll update this PR once the other one is merged

@jonringer
Copy link
Contributor

other has been merged

@jonringer
Copy link
Contributor

i still don't see the cherry-picked from XXXXX in the commit message

@RohanHart
lutris: custom wine installations require libkrb5
042c7f3 
fixes the error: symbol k5_os_mutex_destroy version krb5support_0_MIT not defined in file libkrb5support.so.0

(cherry picked from commit 41fe7db)
@RohanHart
Copy link
Contributor Author

Remembered the -x this time

jonringer
jonringer approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/83655
2 package built:
lutris lutris-free

@jonringer jonringer merged commit 449c060 into NixOS:release-20.03 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RohanHart @jonringer