Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: cca0b749542d
Choose a base ref
...
head repository: NixOS/nixops
compare: 8048f7333067
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 28, 2020

  1. util: Don't check if process.stdin is None unless stdin_string is passed 

    When calling subprocess.Popen passing anything except subprocess.PIPE
as stdin the results stdin attribute is None.

If a file descriptor was passed as stdin we don't want to run this check.
    @adisbladis
    adisbladis committed Mar 28, 2020
    Copy the full SHA
    b3cf86d View commit details
    Browse the repository at this point in the history

  2. Add test for logger in util.py

    @adisbladis
    adisbladis committed Mar 28, 2020
    Copy the full SHA
    abda64d View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1268 from adisbladis/util-fd-fix 

    util: Don't check if process.stdin is None unless stdin_string is passed
    @grahamc
    grahamc committed Mar 28, 2020
    Copy the full SHA
    8048f73 View commit details
    Browse the repository at this point in the history