Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml: default to version 4.09 #83592

Merged
merged 2 commits into from Apr 4, 2020
Merged

OCaml: default to version 4.09 #83592

merged 2 commits into from Apr 4, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Mar 28, 2020

Motivation for this change

nixpkgs is ready for 4.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Mar 28, 2020
View reviewed changes
pkgs/top-level/ocaml-packages.nix
@@ -1232,5 +1232,5 @@ in let inherit (pkgs) callPackage; in rec

ocamlPackages_latest = ocamlPackages_4_10;

ocamlPackages = ocamlPackages_4_08;
ocamlPackages = ocamlPackages_4_09;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are our policies for keeping version of the ocaml compiler though?
Which of these version are still maintained upstream?

@vbgl
Copy link
Contributor Author

vbgl commented Mar 28, 2020 via email

@Mic92
Copy link
Member

Mic92 commented Mar 30, 2020

What are our policies for keeping version of the ocaml compiler though?
IMHO, old compilers should be removed when maintaining them becomes a burden.
Which of these version are still maintained upstream?
I don’t know.

I suppose since we don't build all ocaml package sets this is fine.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 4, 2020 •
edited

@GrahamcOfBorg build acgtk beluga bibtex2html coq2html coq_8_10 eff flow framac hol_light llpp obelisk opam ott patdiff pdfsandwich prooftree proverif reason satallax satysfi stog unison usync why3

@vbgl vbgl merged commit 4dd89ce into NixOS:master Apr 4, 2020
@vbgl vbgl deleted the ocaml-default-4.09 branch April 4, 2020 11:26
@orivej
Copy link
Contributor

orivej commented Apr 5, 2020

ocaml-gettext needs to be updated to unbreak vagrant via libguestfs. (0.3.8 depends on camlp4 which does not support 4.09, 0.4.0 says that it has switched from camlp4 to ppx.)

@vbgl
Copy link
Contributor Author

vbgl commented Apr 6, 2020

Thanks for the report. Sorry for breaking vagrant without noticing it.

I’ll give a try to the update ASAP.

@orivej
Copy link
Contributor

orivej commented Apr 6, 2020

Thank you! (In case updating ocaml-gettext breaks other things, the patch to make the current version support 4.09 is trivial.)

@vbgl
Copy link
Contributor Author

vbgl commented Apr 6, 2020

Here is a PR updating ocaml-gettext: #84457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @orivej