Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mame: add darwin support #83469

Merged
merged 1 commit into from Mar 28, 2020
Merged

mame: add darwin support #83469

merged 1 commit into from Mar 28, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from a user March 27, 2020 07:00
@ofborg ofborg bot requested a review from a user March 27, 2020 17:42
ghost
ghost approved these changes Mar 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veprbl veprbl merged commit 97530e1 into NixOS:master Mar 28, 2020
@veprbl
Copy link
Member Author

veprbl commented Mar 28, 2020

@gnidorah Thank you for reviewing!

@veprbl veprbl deleted the pr/mame_darwin_fix branch March 28, 2020 22:24
@veprbl veprbl restored the pr/mame_darwin_fix branch December 1, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl