buildRustCrateTests: Fix link order test on darwin #83616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
flokli
reviewed
Mar 28, 2020
As it turns out Darwin does most of the things differently then "normal" systems. They are using a different shared library extension and require an obscure commandline parameter that has to be added to every build system out there. That issue seems to be with clang on Darwin as on Linux that flag isn't required to build the very same tests (when using clang). After adjusting these two details the tests are running fine on the darwin box that I was able to obtain.
andir
force-pushed
the
buildRustCrate-fix-link-order-test
branch
from
3562cc5
to
c8de31b
Compare
flokli
approved these changes
Mar 28, 2020
10 tasks
LnL7
approved these changes
Mar 28, 2020
|
On 15:47 28.03.20, Daiderd Jordan wrote:
@LnL7 approved this pull request.
Looks reasonable, assuming there's a reason to not properly link the example `libb` against `liba`.
Yeah, that was intentional since we are trying to simulate a behaviour
of cargo + rustc.
I am a bit baffled that such measures are required on Darwin. On Linux
it just works out of the box. Shouldn't this maybe be handled at a more
generic level within nixpkgs?
|
|
Looks like there are a couple of cases out there, but I've not encountered that before. Presumably things that need this already handle it in their build system making it something we don't really have to worry about. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the tests on Darwin that I broke by merging #83379
cc @kolloch
Things done
sandboxinnix.confon non-NixOS linux)