Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/release-notes: mention that mongodb is unfree now #83617

Merged
merged 1 commit into from Mar 31, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 28, 2020

Motivation for this change

After thinking a bit about this I figured that it might be better to explicitly mention this in the release notes.

For the record, this was suggested previously by @Drakonis. For further context you may want to read https://logs.nix.samueldr.com/nixos-dev/2020-03-26#3227422;

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Mar 28, 2020

FYI currently preparing a PR to backport mongodb 3.4.24, this commit will be part of it :)

@Ma27 Ma27 mentioned this pull request Mar 28, 2020
10 tasks
@Ma27 Ma27 merged commit 12c634c into NixOS:master Mar 31, 2020
@Ma27 Ma27 deleted the mongodb-changelog branch March 31, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant