Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.IMAPClient: 0.13 -> 2.1.0 #82752

Merged
merged 1 commit into from Mar 17, 2020
Merged

pythonPackages.IMAPClient: 0.13 -> 2.1.0 #82752

merged 1 commit into from Mar 17, 2020

Conversation

a1mac
Copy link

@a1mac a1mac commented Mar 16, 2020 •
edited

Motivation for this change

Upgrading IMAPClient - version 0.13 is from 2015.
Was working on python package extract-msg, and it needed the new version. I imagine it will be the case with anything else that has IMAPClient as a dependency.

Things done

Tested for py27, py36, py37 and tested that gmvault builds and runs (has IMAPClient as a dependency).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/imapclient/default.nix Outdated
meta = with stdenv.lib; {
homepage = https://imapclient.readthedocs.io/en/2.1.0/;
homepage = https://imapclient.readthedocs.io/en/2.1.0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't include version information, and quote please (rfc 45)

Suggested change
homepage = https://imapclient.readthedocs.io/en/2.1.0;
homepage = "https://imapclient.readthedocs.io";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you.

jonringer
jonringer approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/82752
4 package built:
gmvault python27Packages.IMAPClient python37Packages.IMAPClient python38Packages.IMAPClient

@jonringer
Copy link
Contributor

@GrahamcOfBorg build gmvault

@jonringer jonringer merged commit 34fd0c0 into NixOS:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a1mac @jonringer