Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip nix store paths from source nixpkgs in packages.json #352

Merged
merged 2 commits into from Mar 16, 2020
Merged

Strip nix store paths from source nixpkgs in packages.json #352

merged 2 commits into from Mar 16, 2020

Conversation

samueldr
Copy link
Member

This removes the accidental inclusion of /nix/store paths in the packages.json file.

This was part of the original expression:

| sed "s|$$nixpkgs/||g" | jq -c . > $@.tmp

It was kept as-is, while it's not a Makefile anymore.

Fixes #349.

@samueldr
Copy link
Member Author

The validation was added as a separate commit so removing it is trivial.

@garbas garbas self-requested a review March 16, 2020 23:07
@garbas garbas added the bug Something isn't working label Mar 16, 2020
@garbas garbas merged commit bfb8442 into NixOS:master Mar 16, 2020
@samueldr samueldr deleted the fix/packages-store-path branch March 16, 2020 23:08
@garbas garbas added this to Done in TODO Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

Assignees

@samueldr samueldr

Labels
bug Something isn't working
Projects
TODO
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paths for nix expressions have /nix/store/l7dndanv2qakp6lbpbndgifk13rwf1ch-source/ prepended
2 participants
@samueldr @garbas