Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tribler: add desktop file, icons and manpages #82750

Merged
merged 1 commit into from May 4, 2020
Merged

tribler: add desktop file, icons and manpages #82750

merged 1 commit into from May 4, 2020

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Mar 16, 2020 •
edited

Motivation for this change

Fixes #82671

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from xvapx March 16, 2020 20:50
@alyssais
Copy link
Member

Are you happy with the email address used in this commit? It’s not associated with your GitHub account.

@mehlon
Copy link
Contributor Author

mehlon commented Mar 17, 2020

Yes. My commits do not have an email address.

@ehmry ehmry merged commit 00a5e1e into NixOS:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xvapx xvapx xvapx approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tribler: missing desktop icons
4 participants
@mehlon @alyssais @xvapx @ehmry