Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZHF] kicad: don't build versions with 3d on Hydra #82760

Merged
merged 1 commit into from Mar 17, 2020
Merged

[ZHF] kicad: don't build versions with 3d on Hydra #82760

merged 1 commit into from Mar 17, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 16, 2020 •
edited

The hydraPlatforms have to be set on the kicad package itself, that can be
checked using:

echo ":p { inherit kicad kicad-small kicad-unstable; }" | nix repl ./pkgs/top-level/release.nix

This commit disables build of all kicad variants that require downloading
packages3d, which currently fail on hydra with the "Output limit exceeded"
status. This leaves Hydra with only building the kicad-small, which will allow
us to cache the build of kicad-base as well as all libraries except of
packages3d.

Motivation for this change

This will stop making Hydra try to build kicad variants that are currently failing.
Some relevant discussion is in #82634

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

#80379

@veprbl
kicad: don't build versions with 3d on Hydra
ebe5f10 
The hydraPlatforms have to be set on the kicad package itself, that can be
checked using:

  echo ":p { inherit kicad kicad-small kicad-unstable; }" | nix repl ./pkgs/top-level/release.nix

This commit disables build of all kicad variants that require downloading
packages3d, which currently fail on hydra with the "Output limit exceeded"
status. This leaves Hydra with only building the kicad-small, which will allow
us to cache the build of kicad-base as well as all libraries except of
packages3d.
@veprbl veprbl changed the title [ZHF] kicad: don't build on Hydra versions with 3d [ZHF] kicad: don't build versions with 3d on Hydra Mar 16, 2020
@veprbl veprbl added this to the 20.03 milestone Mar 16, 2020
@evils
Copy link
Member

evils commented Mar 16, 2020

doh, i completely forgot kicad-small has the same base... thanks!

i'll probably rebase #82634 on this

@evils evils mentioned this pull request Mar 17, 2020
Merged
10 tasks
@evils
Copy link
Member

evils commented Mar 17, 2020

#82634 is now basically a duplicate of this plus a fix and kicad-unstable bump

@veprbl veprbl merged commit e352fcc into NixOS:master Mar 17, 2020
@veprbl veprbl deleted the pr/kicad_fix branch March 17, 2020 03:55
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 17, 2020
@veprbl veprbl self-assigned this Mar 17, 2020
@evils
Copy link
Member

evils commented Mar 17, 2020 •
edited

@veprbl unfortunately this won't fix the kicad-unstable failure since there is no kicad-unstable-small (just adding that doesn't seem like a neat solution...)
and that will result in kicad getting marked as broken since it's all 1 package
unless meta.broken = ( ! stable ); is used, but i'd rather save that as a last resort...

@veprbl
Copy link
Member Author

veprbl commented Mar 17, 2020

@veprbl unfortunately this won't fix the kicad-unstable failure since there is no kicad-unstable-small

I'm aware of this. You could add kicad-unstable-small if you really need it.

(just adding that doesn't seem like a neat solution...)
and that will result in kicad getting marked as broken since it's all 1 package
unless meta.broken = ( ! stable ); is used, but i'd rather save that as a last resort...

I don't understand why you say that kicad-unstable will be marked as broken.

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 17, 2020
@veprbl veprbl removed their assignment Mar 17, 2020
@evils
Copy link
Member

evils commented Mar 18, 2020

I don't understand why you say that kicad-unstable will be marked as broken.

I confused it not building for it failing to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @evils