Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfdb: init at 10.6.2 #82706

Closed
wants to merge 4 commits into from
Closed

wfdb: init at 10.6.2 #82706

wants to merge 4 commits into from

Conversation

maksteel
Copy link

@maksteel maksteel commented Mar 16, 2020 •
edited

Motivation for this change

Wanted to use WFDB with nix on my MacBook and dev Ubuntu HPC.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu 18.04)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@JohnAZoidberg
Copy link
Member

Hi @maksteel, do you still use Nix?
You're using quite an old pure style of derivation, I'm going to make it more modern and nicer.
Not sure if you still want/can to be maintainer?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 5, 2022
@JohnAZoidberg JohnAZoidberg mentioned this pull request Jun 5, 2022
Draft
13 tasks
@JohnAZoidberg
Copy link
Member

Can't push to your branch. Replaced it with a new PR: #176334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maksteel @JohnAZoidberg @ryantm @Janik-Haag