Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for D-dimensional zfp compression #2496

Merged
merged 10 commits into from
Mar 16, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 15, 2020

Still sticking to 2D as it is the sweet spot. Some changes to the ZFP header to avoid size limitations (uncovered in 4D).

Copy link
Member

@eggrobin eggrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test compatibility in-game again.


template<int D>
constexpr std::int64_t NDimensionalHelper<D>::RoundUp(std::int64_t const size) {
// Hacker's Delight, H. S. Warren, Jr., section 3-1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the bibliography, refer to the generated abbreviation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

EXPECT_LE(16'974, compressed.size());
EXPECT_GE(16'974, compressed.size());
EXPECT_LE(16'935, compressed.size());
EXPECT_GE(16'935, compressed.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose things are getting smaller because we lose the metadata header?

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 48 bits per series, I think, and then the vagaries of gipfeli.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Mar 16, 2020
@pleroy pleroy merged commit 51190d8 into mockingbirdnest:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants