-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for D-dimensional zfp compression #2496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test compatibility in-game again.
base/zfp_compressor_body.hpp
Outdated
|
||
template<int D> | ||
constexpr std::int64_t NDimensionalHelper<D>::RoundUp(std::int64_t const size) { | ||
// Hacker's Delight, H. S. Warren, Jr., section 3-1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this to the bibliography, refer to the generated abbreviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
EXPECT_LE(16'974, compressed.size()); | ||
EXPECT_GE(16'974, compressed.size()); | ||
EXPECT_LE(16'935, compressed.size()); | ||
EXPECT_GE(16'935, compressed.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose things are getting smaller because we lose the metadata header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. 48 bits per series, I think, and then the vagaries of gipfeli.
Still sticking to 2D as it is the sweet spot. Some changes to the ZFP header to avoid size limitations (uncovered in 4D).