WIP: Displaying package parameters #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! |
| else | ||
| [] | ||
| else if lib.isList x then | ||
| [] # map (mapRecursively "${n}.list") x |
There was a problem hiding this comment.
Maybe we should raise an error, or actually recurse over it.
This uses a heuristic to only include non-package arguments Also, there seems not to be enough laziness to look into all the derivations; so quite some assertions fail Furthermore, this needs a forked nixpkgs
…to nix (a patched version is needed, see https://github.com/fkz/nix/tree/catch-throw)
namely: - also allow override in callPackagesWith (which doesn't use makeOverridable) - support makeOverridable in the functor case - also build 16.03 channel (not displaying yet) - better error message when parameters couldn't be determined
… parameter only hides it), 15.09 and 16.03 package sets are both displayed
|
[triage] Is this still a relevant feature to be developed for the website? The channel selection would be reimplemented in #209, the part about the package parameter isn't, but probably could be ported. If the feature is desired, but the codebase in need for a rewrite, an issue for the feature request could be opened instead. |
|
closing this due to inactivity, but if needed please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also http://thread.gmane.org/gmane.linux.distributions.nixos/19714
Demo: http://schmitthenner.eu/nixos-homepage/nixos/packages.html
Not yet ready for review but I wanted to start collecting a TODO list at a central place.
TODO for being able to publish
use allow-unsafe-native-code-during-evaluation instead of patching nix (so we don't have to recompile nix)not possible because we added comment (docstring) parsing to the parser of nix nowOther nice additions
vim_configurablethat usescomposableDerivation.nixpkgs/config.nix