You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyexiv2 has been broken for quite a while, but since then it has been rewritten. It no longer has a Boost dependency and now only works on Python 3 (formerly, it only worked on Python 2.)
Only one package depends on pyexiv2, jbrout. However, it is old and broken, so I made a PR to remove it in #82770.
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
NixOS
macOS
other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
The reason will be displayed to describe this comment to others. Learn more.
Ran 0 tests in 0.000s
No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.
No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.
I took a look at what was going on. I'll admit I'm not 100% sure what the deal is because I am not overly familiar with how setuptools integrates with stuff like pytest, however, I suspect that it was not able to resolve the tests because its in a non-standard location (pyexiv2/tests vs tests.) Upstream, it looks like the recommended way of running the tests is by running pytest itself inside the folder, so I made a checkPhase that does this. May be possible to obsolete this by improving the upstream.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stale
bot
added
the
2.status: stale
Motivation for this change
pyexiv2 has been broken for quite a while, but since then it has been rewritten. It no longer has a Boost dependency and now only works on Python 3 (formerly, it only worked on Python 2.)
Only one package depends on pyexiv2, jbrout. However, it is old and broken, so I made a PR to remove it in #82770.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)