New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
engelsystem: init at 3.1.0 #82753
engelsystem: init at 3.1.0 #82753
Conversation
It does not seem like this adds a NixOS module. I am unsure how useful this package is without a module. |
will make it to an WIP, and add the module for it |
20eb3b2
to
5ff3f8e
Compare
We can merge the package first, without a module. It can still be useful to people who write their own configuration (non-reusable modules), or even to people who don’t run NixOS. |
Don’t do either in the package — the NixOS module should handle those. |
What I ment are both of the symlinks one pointing to etc, and one pointing to /var/lib |
The symlinks in the derivation look fine to me. |
5ff3f8e
to
09d6025
Compare
@Mic92 look at the code. There are two symlinks that are basically no-ops AFAICT because they link to the build directory in the installPhase. |
@alyssais which two? I only have three symlinks, one to /var/lib/engelsystem one to /etc/engelsystem/config.php and one to the migrate script inside the package. all three are working on my side |
Those symlinks are than copied to $out with the rest of the source later, so this is correct. |
I'm just implementing the module for it, becaus I probably have to change the migrate script for that. The proplem I have is how to escape '' in a '' ... '' block? I found this solution, but it seems ugly: '${""}' |
7f83e0f
to
a92d124
Compare
a8d1036
to
5511b51
Compare
Works in my prod env, without any user setup, besides changing the admin pass via the web interface |
5511b51
to
66767ec
Compare
66767ec
to
9ce6540
Compare
9ce6540
to
1589d6a
Compare
1589d6a
to
5bff524
Compare
ca969c2
to
2a7566b
Compare
2a7566b
to
da4b95c
Compare
@GrahamcOfBorg test engelsystem |
@Kloenk I fixed some small issues and added a test. If you want to squash the fixes into your commit, I'm fine with that - I just didn't want to get rid of your gpg signature. The test should probably stay in its own commit, though. :) |
@talyz I like the changes. Should I squash them to make |
Yeah, squash the fixes, but not the test. |
b4a447d
to
1e343d1
Compare
Squashed. Can someone write ofborg to restest it? |
@GrahamcOfBorg test engelsystem |
Great work! Thanks! 👍 |
Motivation for this change
provide engelsystem as a module, so it can be easily hosted via nixos, without the use of docker
Things done
init engelsystem.
I'm still unsure of the way of handling the storage directory and the config file
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)