Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket: enable building on aarch64 #82728

Merged
merged 1 commit into from Mar 24, 2020
Merged

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Mar 16, 2020

Motivation for this change

It builts successfully on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs
Copy link
Contributor Author

bennofs commented Mar 20, 2020

CC @kkallio @henrytill @vrthra maintainers

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build succeeds on aarch64.nixos.community. I'll assume you've tested it a bit more.

EDIT: seems suitable for 20.03 as well.

@bennofs
Copy link
Contributor Author

bennofs commented Mar 20, 2020

I've checked that drracket starts and displays a GUI

@vcunat vcunat merged commit a533068 into NixOS:master Mar 24, 2020
vcunat added a commit that referenced this pull request Mar 24, 2020
(cherry picked from commit a533068)
Build re-tested on 20.03.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants