Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coc-go: use npm module #82723

Closed
wants to merge 1 commit into from
Closed

coc-go: use npm module #82723

wants to merge 1 commit into from

Conversation

eyJhb
Copy link
Member

@eyJhb eyJhb commented Mar 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eyJhb eyJhb requested a review from jonringer as a code owner March 16, 2020 11:29
@jbaum98 jbaum98 mentioned this pull request Sep 3, 2020
Merged
10 tasks
@eyJhb
Copy link
Member Author

eyJhb commented Oct 28, 2020

Closing because of #96993

@eyJhb eyJhb closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eyJhb @jonringer @ryantm