Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuweb: 1.58 -> 1.60, fix build #82712

Merged
merged 3 commits into from Mar 17, 2020
Merged

nuweb: 1.58 -> 1.60, fix build #82712

merged 3 commits into from Mar 17, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 16, 2020

Motivation for this change

Build broken by #82199

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl mentioned this pull request Mar 16, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from AndersonTorres March 16, 2020 06:40
@veprbl veprbl merged commit 0bd52ef into NixOS:master Mar 17, 2020
@veprbl veprbl deleted the pr/nuweb_fix branch March 18, 2020 09:40
@veprbl veprbl restored the pr/nuweb_fix branch December 1, 2020 16:45
@veprbl veprbl deleted the pr/nuweb_fix branch December 1, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@veprbl