Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 06160e5052a3
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ffb9db4191ad
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Mar 16, 2020

  1. Copy the full SHA
    5981332 View commit details
  2. Merge pull request #2498 from pleroy/Clang

    Make the ZFP static_assert work on all compilers
    pleroy authored Mar 16, 2020
    Copy the full SHA
    ffb9db4 View commit details
Showing with 1 addition and 4 deletions.
  1. +1 −4 base/zfp_compressor_body.hpp
5 changes: 1 addition & 4 deletions base/zfp_compressor_body.hpp
Original file line number Diff line number Diff line change
@@ -68,10 +68,7 @@ NDimensionalHelper<D>::NewField(zfp_type const type, std::vector<double>& v) {
/*nw=*/v.size() / padding_),
std::move(free));
} else {
#if PRINCIPIA_COMPILER_MSVC
// Clang doesn't seem to discard the else part.
static_assert(false, "Unsupported dimension");
#endif
static_assert(D >= 1 && D <= 4, "Unsupported dimension");
}
}