Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtxc_dxtn{,_s2tc}: remove from nixpkgs + hardware.opengl options #82714

Merged
merged 1 commit into from
Apr 20, 2020
Merged

libtxc_dxtn{,_s2tc}: remove from nixpkgs + hardware.opengl options #82714

merged 1 commit into from
Apr 20, 2020
+10 −78

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 16, 2020

Motivation for this change

Context: discussion in #82630

Mesa has been supporting S3TC natively without requiring these libraries
since the S3TC patent expired in December 2017.

Fixes #82627 .

@GrahamcOfBorg build wine-staging lutris

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 16, 2020
@delroth delroth force-pushed the s3tc branch 2 times, most recently from bca6bf1 to cdd5d28 Compare March 16, 2020 08:46
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 16, 2020
@Ekleog
Copy link
Member

Ekleog commented Apr 19, 2020

@delroth I wanted to review and hopefully merge this, but it looks like merge conflicts arose… could you rebase? :)

@delroth
libtxc_dxtn{,_s2tc}: remove from nixpkgs + hardware.opengl options
1b89bff 
Context: discussion in NixOS#82630

Mesa has been supporting S3TC natively without requiring these libraries
since the S3TC patent expired in December 2017.
@delroth
Copy link
Contributor Author

delroth commented Apr 20, 2020

Rebased.

@delroth
Copy link
Contributor Author

delroth commented Apr 20, 2020

@GrahamcOfBorg build wine-staging lutris

@Ekleog Ekleog merged commit 203955f into NixOS:master Apr 20, 2020
@Ekleog
Copy link
Member

Ekleog commented Apr 20, 2020

Looks good to me, thank you!

@ldesgoui ldesgoui mentioned this pull request Jun 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/opengl: consider enabling S3TC by default
3 participants
@delroth @Ekleog @vcunat